Merged
Conversation
paulromano
requested changes
Jan 11, 2023
Contributor
paulromano
left a comment
paulromano
left a comment
There was a problem hiding this comment.
Thanks @shimwell. Two trivial change requests:
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #2326 which got a bit conflicted with the develop branch after #2291 was merged in.
This PR attempts to allow the materials.xml filename / filepath to be specified when creating a geometry from a xml file. Perhaps this is slightly more flexible that the hard coded use of 'materials.xml' which we have currently.
I have added to the existing test to check the geometry is still loaded for a few different combinations of arguments.
Also it opens up the potential use of materials=None to pass in no materials. In the longer term I would be keen to propose the option of no materials when loading the geometry.