Skip to content

Flag to disable TLS handling by proxy#18

Merged
richturner merged 4 commits intomainfrom
enhancement/tls-disable
Mar 30, 2026
Merged

Flag to disable TLS handling by proxy#18
richturner merged 4 commits intomainfrom
enhancement/tls-disable

Conversation

@ebariaux
Copy link
Copy Markdown
Contributor

Allows to deploy HAProxy but terminate the TLS connections before entering the proxy container.

@ebariaux ebariaux added the Enhancement Improvement of an existing feature label Mar 27, 2026
@ebariaux ebariaux requested a review from a team March 27, 2026 12:35
@wborn wborn requested a review from Copilot March 27, 2026 15:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for deployments where TLS is terminated upstream of the proxy container (e.g., ALB/NLB/Ingress), so HAProxy can run with plain HTTP/TCP while still forwarding the expected X-Forwarded-* headers.

Changes:

  • Add an edge-terminated HAProxy config that removes local TLS/cert usage and MQTT TLS handling.
  • Introduce DISABLE_ACME to skip certbot initialization and renewal logic in entrypoint.sh.
  • Document the new deployment mode and config selection in README.md, and ship the new config in the image.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
haproxy-edge-terminated-tls.cfg New HAProxy config for plain HTTP + plain TCP MQTT when TLS is terminated upstream.
entrypoint.sh Adds DISABLE_ACME gating for certbot/cron initialization and auto-renew behavior.
README.md Documents DISABLE_ACME and provides setup steps for edge-terminated TLS.
Dockerfile Copies the new HAProxy config into the image.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@richturner richturner merged commit 66d32b3 into main Mar 30, 2026
@richturner richturner deleted the enhancement/tls-disable branch March 30, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants