Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for deployments where TLS is terminated upstream of the proxy container (e.g., ALB/NLB/Ingress), so HAProxy can run with plain HTTP/TCP while still forwarding the expected X-Forwarded-* headers.
Changes:
- Add an edge-terminated HAProxy config that removes local TLS/cert usage and MQTT TLS handling.
- Introduce
DISABLE_ACMEto skip certbot initialization and renewal logic inentrypoint.sh. - Document the new deployment mode and config selection in
README.md, and ship the new config in the image.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| haproxy-edge-terminated-tls.cfg | New HAProxy config for plain HTTP + plain TCP MQTT when TLS is terminated upstream. |
| entrypoint.sh | Adds DISABLE_ACME gating for certbot/cron initialization and auto-renew behavior. |
| README.md | Documents DISABLE_ACME and provides setup steps for edge-terminated TLS. |
| Dockerfile | Copies the new HAProxy config into the image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
richturner
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to deploy HAProxy but terminate the TLS connections before entering the proxy container.