Skip to content

Enhance Java Agent to intercept System::exit#17746

Merged
reta merged 2 commits intoopensearch-project:mainfrom
reta:issue-17723
Apr 1, 2025
Merged

Enhance Java Agent to intercept System::exit#17746
reta merged 2 commits intoopensearch-project:mainfrom
reta:issue-17723

Conversation

@reta
Copy link
Contributor

@reta reta commented Apr 1, 2025

Description

Enhance Java Agent to intercept System::exit

Related Issues

Closes #17723

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <drreta@gmail.com>
Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @reta! Left a few comments, but LGTM. Nice work on the test for this.

Signed-off-by: Andriy Redko <drreta@gmail.com>
@reta
Copy link
Contributor Author

reta commented Apr 1, 2025

Thank you @reta! Left a few comments, but LGTM. Nice work on the test for this.

Thanks a lot for the review @cwperks , comments addressed!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

❌ Gradle check result for 22cfda0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

❕ Gradle check result for 22cfda0: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 72.48%. Comparing base (8182bb0) to head (22cfda0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rg/opensearch/javaagent/SystemExitInterceptor.java 0.00% 6 Missing ⚠️
.../src/main/java/org/opensearch/javaagent/Agent.java 0.00% 5 Missing ⚠️
...rg/opensearch/javaagent/bootstrap/AgentPolicy.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17746      +/-   ##
============================================
+ Coverage     72.29%   72.48%   +0.19%     
- Complexity    65900    66114     +214     
============================================
  Files          5350     5351       +1     
  Lines        306185   306220      +35     
  Branches      44373    44376       +3     
============================================
+ Hits         221347   221970     +623     
+ Misses        66670    66120     -550     
+ Partials      18168    18130      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reta reta merged commit 15d27a1 into opensearch-project:main Apr 1, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request security Anything security related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Enhance Java Agent to intercept System::exit

2 participants