[Rule-based Auto-tagging] add the schema for security attributes#19345
[Rule-based Auto-tagging] add the schema for security attributes#19345jainankitk merged 3 commits intoopensearch-project:mainfrom
Conversation
2819463 to
eefa8d2
Compare
jainankitk
left a comment
There was a problem hiding this comment.
Thanks @ruai0511! Changes look more consumable as separate small PRs. Mostly LGTM, just few comments to understand the changes better
modules/autotagging-commons/common/src/main/java/org/opensearch/rule/RuleAttribute.java
Outdated
Show resolved
Hide resolved
modules/autotagging-commons/common/src/main/java/org/opensearch/rule/SecurityAttribute.java
Outdated
Show resolved
Hide resolved
modules/autotagging-commons/common/src/main/java/org/opensearch/rule/SecurityAttribute.java
Outdated
Show resolved
Hide resolved
modules/autotagging-commons/common/src/main/java/org/opensearch/rule/SecurityAttribute.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for eefa8d2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
modules/autotagging-commons/common/src/main/java/org/opensearch/rule/SecurityAttribute.java
Outdated
Show resolved
Hide resolved
a694b23 to
c059395
Compare
|
❌ Gradle check result for c059395: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Unrelated test failure: @ruai0511 - Can you merge from the main branch? |
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
c059395 to
639bd3b
Compare
|
❌ Gradle check result for 639bd3b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
639bd3b to
97e899d
Compare
|
❌ Gradle check result for 97e899d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Unrelated failures: Retrying gradle check. @peteralfonsi - Can you check the failure related to FDC once? - https://build.ci.opensearch.org/job/gradle-check/64284/testReport/junit/org.opensearch.index.fielddata/FieldDataLoadingIT/testIndicesFieldDataCacheSizeSetting/ |
|
❌ Gradle check result for 97e899d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
97e899d to
d7fd516
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19345 +/- ##
============================================
+ Coverage 72.90% 72.97% +0.06%
+ Complexity 69915 69887 -28
============================================
Files 5675 5675
Lines 320841 320893 +52
Branches 46387 46391 +4
============================================
+ Hits 233909 234164 +255
+ Misses 68031 67745 -286
- Partials 18901 18984 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
…nsearch-project#19345) Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
…nsearch-project#19345) Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
…nsearch-project#19345) Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
This PR enhances rule-based auto-tagging functionality by introducing security-related attributes. Specifically, we aim to extract user information (username and role) from the security context of incoming requests. In many real-world environments, security context is essential for customers with multiple teams, departments, or security boundaries. By enabling the use of security attributes in auto-tagging rules, this project will provide more practical and convenient ways to define the tenants.
This PR includes:
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.