Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

check is Facility#116

Closed
giggsoff wants to merge 1 commit intopackethost:masterfrom
giggsoff:fix-facility
Closed

check is Facility#116
giggsoff wants to merge 1 commit intopackethost:masterfrom
giggsoff:fix-facility

Conversation

@giggsoff
Copy link
Copy Markdown

I try to obtain ips for device without success:

Traceback (most recent call last):
  File "/workspace-private/zintegrationtestutils/packet.py", line 156, in is_public_address_ready
    ip_addresses = self.pkt_instance.ips()
  File "/usr/local/lib/python3.8/site-packages/packet/Device.py", line 106, in ips
    return self.manager.list_device_ips(self.id)
  File "/usr/local/lib/python3.8/site-packages/packet/Manager.py", line 368, in list_device_ips
    ip = IPAddress(jsoned, self)
  File "/usr/local/lib/python3.8/site-packages/packet/IPAddress.py", line 25, in __init__
    self.facility = Facility(data.get("facility"))
  File "/usr/local/lib/python3.8/site-packages/packet/Facility.py", line 7, in __init__
    self.id = data.get("id")
AttributeError: 'NoneType' object has no attribute 'get'

Seems, that facility field is null for my case:

"ip_addresses": [
		{
			"id": "c0b3e747-f85f-4abc-89c0-6683964a1d3c",
...
			"href": "/metal/v1/ips/c0b3e747-f85f-4abc-89c0-6683964a1d3c",
			"facility": null
		}
...
]

Signed-off-by: Petr Fedchenkov giggsoff@gmail.com

Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
@displague
Copy link
Copy Markdown
Member

Thanks for this PR, @giggsoff .

We actually have this change proposed in https://github.com/packethost/packet-python/pull/110/files#diff-3522ca1c96d4e5ee701cee05ad8f930db2db0737f39db8e78a0def08a132e7bcR34

I'm going to close this PR for the more comprehensive set of metro-related changes and I'll ping folks for review.

@displague displague closed this May 18, 2021
@giggsoff
Copy link
Copy Markdown
Author

Thank you!
Will wait for another PR to merge.

@displague displague mentioned this pull request May 20, 2021
@displague
Copy link
Copy Markdown
Member

fix released in 1.44.0

@giggsoff
Copy link
Copy Markdown
Author

Thanks for mentioning me, the new version works well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants