Merged
Conversation
TiiFuchs
approved these changes
Apr 26, 2023
Member
TiiFuchs
left a comment
There was a problem hiding this comment.
You have my respect and gratitude.
I hereby approve thee changes.
Collaborator
|
Seems like changes about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The long awaited PR to update to the latest Bot API 6.7 🎉
@TiiFuchs Feedback welcome of course.
I'm wondering if the new entity classes should be organised differently. Like all the
Bot*into aBotfolder andInlineQuery*ones into the existingInlineQueryone?Also, I've introduced a public static variable
Entity::$fixThumbnailRenamewhich istrueby default, which should make sure that bots using the oldthumbfield and method calls don't suddenly break. It converts all foundthumbfields and method names tothumbnail.Also notice the improved result objects returned in the
ServerResponseobject.I've not done extensive testing yet.