Remove backported revcheck compatibility#176
Merged
alfsb merged 23 commits intophp:masterfrom Nov 14, 2024
Merged
Conversation
Girgias
reviewed
Nov 12, 2024
Member
Author
|
Merged. Now, local revcheck will slight differ from hosted revcheck, as it is tracking I do plan make two, possibly three changes (robust log parsing, strict rev-skip positioning, visual tweaks), beyond the already opened PR for sequential skip-revcheck. Let me know if systems people want to wait to all changes before updating, or want to mentioned or have issues opened in each instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes some of backported revcheck behaviors, that seems incorrect or makes count debugging difficult. They new behaviors are:
chmonly/as translatable;extensions.xmlas translatable;The first change will include 4 files as translatable, the second will mark one file as translatable and possibly a few as NotInEn. The last does not change file tracking or listing, but it causes a lot of changes on translator listing.
What it does is counting Ok and Old cases in separated counters, and push all other situations on a "Other" counter. So after this, file count and file listing of outdated cases will match, and RevtagProblem will not be counted as Outdated.
Note that RevtagProblem cannot be listed alongside with Outdated anyways, because it's not possible to generate diff links in this case. This changes will make count debug vastly easier, as it removes all instances of possibly not counted cases in a lot of corner cases.
Reviews and commentary welcome. I plan to push this PR next week if there are no objections.
This PR supersedes #175.