fix: remove cd before call to spc dump-extensions#2328
Open
fix: remove cd before call to spc dump-extensions#2328
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the working-directory handling in build-static.sh when deriving PHP_EXTENSIONS in EMBED mode, ensuring the spc dump-extensions call doesn’t invalidate prior cd operations needed for subsequent spcCommand invocations.
Changes:
- Remove
cd "${EMBED}"before callingspc dump-extensions "${EMBED}", preventing the script from leaving thestatic-php-cli/directory unexpectedly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why this
cdis in place since this invalidates the previouscdcalls for thespcCommandto work. It also makes no sense since the${EMBED}is passed as an argument here.Or perhaps I am missing something?