This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Merged
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edit:
This PR is becoming much bigger than expected, apologies in advance if the commit history or comments are not super clear.
This updates the
Inputcomponent with a newdebounceprop that determines whensetPropsis called, should fix #169. It also adds a bunch of unit tests, and fixes an issue where props coming fromdash-rendererwould overwrite the current state of the input. That last bug is more common than we think - components that usestateas well assetPropsget out of sync often.Here's an example app with the new
debounceprop:It also fixes #292 by fixing the
stepprop and #173 by not updating value if <minor >max.Also renamed a couple of props that weren't being picked up by React, similarly to #348.