Conversation
valentijnnieman
left a comment
There was a problem hiding this comment.
Hmm looks like something's not quite right in that Percy screenshot. I also don't think it's a good idea to move the dev requirements file into .circle, it's not only needed by CircleCI - it's also needed for developing locally.
|
I wanted to mirror the changes here.
That PR does all of these well, I agree that the location is probably not the best. I think a plain |
|
What do you think about the same changes just with |
|
It was asked to move them in dash because it caused confusion for people looking at the repo and the old |
|
Okay that makes sense. I'll add a comment, and perhaps we should name it |
|
@valentijnnieman Moved that file back, also figured out the Percy error (the package to load excel files wasn't included in the dev requirements 🙈) |
|
Cool, that looks good to me! |
|
Not making release as this PR only changes testing / dev requirements. |
Quick cleanup of the requirements files.