Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Update requirements#372

Merged
rmarren1 merged 5 commits intomasterfrom
update-requirements
Nov 9, 2018
Merged

Update requirements#372
rmarren1 merged 5 commits intomasterfrom
update-requirements

Conversation

@rmarren1
Copy link
Copy Markdown
Contributor

@rmarren1 rmarren1 commented Nov 8, 2018

Quick cleanup of the requirements files.

Copy link
Copy Markdown
Contributor

@valentijnnieman valentijnnieman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm looks like something's not quite right in that Percy screenshot. I also don't think it's a good idea to move the dev requirements file into .circle, it's not only needed by CircleCI - it's also needed for developing locally.

@rmarren1
Copy link
Copy Markdown
Contributor Author

rmarren1 commented Nov 8, 2018

I wanted to mirror the changes here.
I think it is important to

  1. keep the location of these files consistent throughout all main repos (dcc, dash, html)
  2. only have one requirements file to install dev requirements (or > 1 in the case that there are significant differences between python versions)
  3. keep these files minimal, preferably with the install_requires packages plus selenium and percy so that the most up to date packages are installed in CI, and so the github security alerts go away

That PR does all of these well, I agree that the location is probably not the best. I think a plain requirements.txt file at the top level is expected, finding it in the hidden .circleci folder might make it difficult for brand new developers to get started.

@rmarren1
Copy link
Copy Markdown
Contributor Author

rmarren1 commented Nov 8, 2018

What do you think about the same changes just with .circleci/requirements/dev.txt moved to requirements.txt? I could mirror these in dash and dash-html-components as well.

@T4rk1n
Copy link
Copy Markdown
Contributor

T4rk1n commented Nov 8, 2018

It was asked to move them in dash because it caused confusion for people looking at the repo and the old requirements.txt was all locked with old versions that would cause problems when installed. Maybe add it back with all unlocked versions of true dependencies with a comment on top saying theses requirements are for dev purpose only.

@rmarren1
Copy link
Copy Markdown
Contributor Author

rmarren1 commented Nov 8, 2018

Okay that makes sense. I'll add a comment, and perhaps we should name it dev-requirements.txt instead to be super explicit as to what they are there for.

@rmarren1
Copy link
Copy Markdown
Contributor Author

rmarren1 commented Nov 8, 2018

@valentijnnieman Moved that file back, also figured out the Percy error (the package to load excel files wasn't included in the dev requirements 🙈)

@valentijnnieman
Copy link
Copy Markdown
Contributor

Cool, that looks good to me!

@rmarren1
Copy link
Copy Markdown
Contributor Author

rmarren1 commented Nov 9, 2018

Not making release as this PR only changes testing / dev requirements.

@rmarren1 rmarren1 merged commit a8ebbf8 into master Nov 9, 2018
@rmarren1 rmarren1 deleted the update-requirements branch November 9, 2018 02:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants