This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Update R dashHtmlComponents package to 0.13.5#91
Merged
Conversation
Collaborator
|
I'm not an R user, so can't comment on the code there, but it all looks good - and seems there are no references to events 🎉 Can you drop the built python files from this PR, since all they do is revert the changes I made in #89 with the as-yet-unpublished changes I made to the python codegen code? |
This was referenced Jan 18, 2019
T4rk1n
suggested changes
Jan 28, 2019
Contributor
T4rk1n
left a comment
T4rk1n
left a comment
There was a problem hiding this comment.
The props order for python component shouldn't change.
rpkyle
changed the title
Contributor
Author
@T4rk1n If you could look over the recent commit, that'd be great. Hopefully we're nearing 💃. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON >> R 'transpiler' has been rewritten in Python, and was used to generate an installable R package for version 0.13.5 of
dash-html-components. This PR closes #74.@alexcjohnson @nicolaskruchten @T4rk1n @Marc-Andre-Rivet