Skip to content

Add assets css to percy snapshots#461

Merged
T4rk1n merged 3 commits intomasterfrom
assets-snapshots
Nov 19, 2018
Merged

Add assets css to percy snapshots#461
T4rk1n merged 3 commits intomasterfrom
assets-snapshots

Conversation

@T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Nov 19, 2018

No description provided.

Copy link
Contributor

@valentijnnieman valentijnnieman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good, the Percy snapshots show that the CSS is being loaded. I'm not quite sure about the last few snapshots that changed, they don't really show much of a difference.

@T4rk1n
Copy link
Contributor Author

T4rk1n commented Nov 19, 2018

Those snapshot changed because of the reset.css changing the body to 0 padding.

@T4rk1n T4rk1n merged commit dcd0f41 into master Nov 19, 2018
@T4rk1n T4rk1n deleted the assets-snapshots branch November 19, 2018 20:51
AnnMarieW pushed a commit to AnnMarieW/dash that referenced this pull request Jan 6, 2022
Enhancement: add property Graph.extendData to support Plotly.extendTraces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants