Conversation
This was referenced Dec 6, 2018
Closed
T4rk1n
requested changes
Dec 10, 2018
Contributor
There was a problem hiding this comment.
- Move big templates string as global at top of the file to make methods logic more readable.
- Improve the docstrings.
- Add
--r-prefixoption. - Call
os.makedirsonly once in component_generator. - Imports at top of files.
- Copy the whole js/css dist.
-
generate_rpkgshould use.getfor field access, can't be sure that apackage.jsonwill contain some the fields used.
added 20 commits
December 11, 2018 11:46
T4rk1n
reviewed
Dec 13, 2018
T4rk1n
reviewed
Dec 13, 2018
T4rk1n
approved these changes
Dec 13, 2018
Contributor
T4rk1n
left a comment
There was a problem hiding this comment.
Looking good, just need to fix json_to_r_type and I think we're good to go.
rmarren1
approved these changes
Dec 13, 2018
Contributor
rmarren1
left a comment
There was a problem hiding this comment.
Few comments, looks good overall!
Contributor
Author
|
Thanks for the additional reviews, I think the code has improved a lot -- both due to the useful factoring of the component generation in @T4rk1n and I had a nice chat about
As for the other options:
|
Contributor
Author
|
@T4rk1n Following up on our conversation from Friday, how does this version of |
added 5 commits
December 17, 2018 16:18
Contributor
Author
AnnMarieW
pushed a commit
to AnnMarieW/dash
that referenced
this pull request
Jan 6, 2022
Modified Graph.react.js to include restyle event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK, I've taken a stab at using the new generator method approach to component generation for R. If you two don't mind having another look, would be much appreciated. Closes #445.
@rmarren1 @T4rk1n
(N.B. This PR is the up-to-date version of this closed PR)