You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a test PR, mainly to get the ball rolling and see what would happen if we simply applied standard formatting. There are lots of rules that will require manual rewriting.
In particular, the vast majority look like
convert.js:219:72: ':' should be placed at the beginning of the line.
index.js:34:3: Split initialized 'var' declarations into multiple statements.
It's probably a couple hour pass to go through and fix those, then a bit more work to figure out maybe a few more subtle issues.
Common sentiment overheard: "OMG eslint is just horrible to have to run all the time. prettier solves this whole problem in a way that makes fundamentally so much more sense. So over eslint." Paraphrasing, of course. People seem very excited about dumping eslint for prettier though. In summary, eslint 'fixes' your code by tweaking it. Prettier parses the AST, dumps the original code, and reprints it with perfectly consistent and standardized formatting.
If I understand then, there aren't rules to violate. You write code. It reinterprets it and applies its own formatting. Seems nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test PR, mainly to get the ball rolling and see what would happen if we simply applied standard formatting. There are lots of rules that will require manual rewriting.
In particular, the vast majority look like
It's probably a couple hour pass to go through and fix those, then a bit more work to figure out maybe a few more subtle issues.
See: #950 ping @etpinard