Fix hover on mobile and tablet devices for gl3d subplots#5239
Merged
archmoj merged 5 commits intoplotly:masterfrom Nov 2, 2020
Merged
Fix hover on mobile and tablet devices for gl3d subplots#5239archmoj merged 5 commits intoplotly:masterfrom
archmoj merged 5 commits intoplotly:masterfrom
Conversation
Contributor
|
Thanks very much for the PR! plotly.js/test/jasmine/tests/gl3d_plot_interact_test.js Lines 929 to 971 in 0fce11b @jdpaterson could you please investigate why? |
archmoj
reviewed
Oct 29, 2020
use non-blocking assert syntax
Contributor
Author
|
@archmoj the test-bundle timed out during the mapbox plot tests. Is this something I should be concerned about here? |
Contributor
@jdpaterson No. I'll re-run the container tomorrow. |
archmoj
reviewed
Oct 30, 2020
Contributor
|
Nicely done! 🥇 🎖️ @jdpaterson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update gl-plot3d version to fix #4550 .
Related to gl-vis/gl-plot3d#31