Conversation
Contributor
|
2 questions:
|
Contributor
Author
My first reaction is that this would be a bit too magical. I'm comfortable with changing the renderer based on an external environment variable since rendering is inherently context dependent But turning on v4 mode externally would change the semantics of the code with no trace of why it changed.
|
Contributor
|
For 1 I agree in general of course I just through it might make doc writing a bit smoother until the launch :) no big deal either way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1559
Support specifying the default renderer using the
PLOTLY_RENDERERenvironment variable. This environment variable is only checked when therenderer_defaultsfuture flag is set.cc @nicolaskruchten