Draft
Conversation
bd5dea9 to
2b66470
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
Closes #5537
Description of change
setuptoolstohatch(hatchis distributed by PyPA and has a number of advantages compared tosetuptoolspyproject.tomlconfig to work withhatch, and remove unused config sectionsMANIFEST.infile, since it's only required bysetuptools, not needed forhatchjs/package.jsonto reflect the correct version number matching plotly.py version, which we've forgotten to do for the last few releasesRELEASE.mdinstructions to add step to update version number injs/package.jsonjs/install.jsonfile which I believe are not neededNOTE: The build command remains the same:
python -m build .Demo
python-m-build.mov
When running
python -m build .locally, the output should look like the above.Testing strategy
No additional testing needed: The CI already runs
python -m build ., so if that step fails then we know something is wrong.However, we should verify manually that the resulting build is the same before and after these changes.
This can be done by checking out this branch, running
python -m build ., and comparing the.tar.gzand.whlfiles to the official 6.6.0 release artifacts.Guidelines