Closed
Conversation
…v of the uri if the uri is already loaded
…ihp/client_config_interfaces
…ig_builder_set_many_envs - AttributeError: 'ClientConfigBuilder' object has no attribute 'config'
Contributor
Author
|
with the current set up getting the following error: FAILED this is probably due to some syntax errors. this is how set up the various classes right now. from abc import ABC, abstractmethod
@dataclass(slots=True, kw_only=True)
class ClientConfig:
"""
This Abstract class is used to configure the polywrap client before it executes a call
The ClientConfig class is created and modified with the ClientConfigBuilder module
"""
envs: Dict[Uri, Dict[str, Any]]
interfaces: Dict[Uri, List[Uri]]
resolver: IUriResolver
class IClientConfigBuilder(ABC):
@abstractmethod
def build() -> ClientConfig:
"""Returns a sanitized config object from the builder's config."""
pass
class BaseClientConfigBuilder(IClientConfigBuilder):
"""A concrete class of the Client Config Builder, which uses the IClientConfigBuilder Abstract Base Class"""
# config: ClientConfig
def __init__(self):
self.config.envs = {}
self.config.interfaces = {}
self.config.resolver = None
...
class ClientConfigBuilder(BaseClientConfigBuilder):
...Another alternative I could try calling is |
Contributor
Author
|
The above error has been solved yesterday and now working further in the implementation of wrappers as an attribute of the just hace to do some cleanup and do a PR with WIP |
Contributor
Author
|
closing pr in favor of #52 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #5
Continuing from #38
This PR would implement the a new
client config builderpackage, according to the recent changes of the JS Polywrap Client v0.10JS PR that implements this: polywrap/wrap-cli#1367