Use Bazelisk instead of Bazel in GitHub Actions.#504
Draft
PiotrSikora wants to merge 2 commits intoproxy-wasm:mainfrom
Draft
Use Bazelisk instead of Bazel in GitHub Actions.#504PiotrSikora wants to merge 2 commits intoproxy-wasm:mainfrom
PiotrSikora wants to merge 2 commits intoproxy-wasm:mainfrom
Conversation
bazel-contrib/setup-bazel installs only "bazelisk" binary, not "bazel". The existing jobs worked on hosted GitHub runners, since both binaries are preinstalled, but "bazel" is not available when testing locally. Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
PiotrSikora
requested review from
leonm1,
martijneken and
mpwarres
as code owners
Member
Author
|
This is blocked on #492 (s390x), since its Docker image doesn't have |
Contributor
|
Any argument against closing this PR? It will be forever blocked since we have decided to continue using s390x in CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bazel-contrib/setup-bazel installs only "bazelisk" binary, not "bazel".
The existing jobs worked on hosted GitHub runners, since both binaries
are preinstalled, but "bazel" is not available when testing locally.