fix: provide useful behavior of default py::slice#5620
Merged
henryiii merged 3 commits intopybind:masterfrom Apr 16, 2025
Merged
fix: provide useful behavior of default py::slice#5620henryiii merged 3 commits intopybind:masterfrom
py::slice#5620henryiii merged 3 commits intopybind:masterfrom
Conversation
henryiii
reviewed
Apr 16, 2025
henryiii
reviewed
Apr 16, 2025
py::slice
Contributor
Author
|
@henryiii I don't quite understand your comments - the code you are commenting on was not changed by my commit. Shall I commit your change suggestions? |
Collaborator
|
I commented the suggestion. Yes, it was just right next to your changes and might have contributed to your confusion in #5579 about the end point. I think this looks good now! |
henryiii
approved these changes
Apr 16, 2025
b-pass
pushed a commit
to b-pass/pybind11
that referenced
this pull request
May 9, 2025
* Change behavior of default py::slice * make clang-tidy happy * Update tests/test_pytypes.py --------- Co-authored-by: Bryn Lloyd <12702862+dyollb@users.noreply.github.com> Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the behavior of the default constructor of
py::sliceto be equivalent tovals[::]. I converted a large code base from boost::python to pybind11, and one of the stumbling blocks was this issue (see #5579).Without this change, calling
a[py::slice()]leads to an error, e.g. like this:______________________________________________________________________________________ test_list_slicing _______________________________________________________________________________________ def test_list_slicing(): li = list(range(100)) assert li[::2] == m.test_list_slicing(li) > assert li[::] == m.test_list_slicing_default(li) E SystemError: null argument to internal routine li = [0, 1, 2, 3, 4, 5, ...] ../../tests/test_pytypes.py:607: SystemErrorSuggested changelog entry: