Skip to content

Fix *args/**kwargs return types. Add type hinting to py::make_tuple #5881

Merged
rwgk merged 6 commits intopybind:masterfrom
InvincibleRMC:type-make_tuple-fix--args/--kwargs-return-type
Nov 14, 2025
Merged

Fix *args/**kwargs return types. Add type hinting to py::make_tuple #5881
rwgk merged 6 commits intopybind:masterfrom
InvincibleRMC:type-make_tuple-fix--args/--kwargs-return-type

Conversation

@InvincibleRMC
Copy link
Copy Markdown
Contributor

@InvincibleRMC InvincibleRMC commented Oct 26, 2025 •
edited
Loading

Description

While working on #5879. I noticed the return type of py::args/py::kwargs was wrong.

Update the return type of py::args/py::kwargs. Also updated make_tuple to use typing::Tuple similar to how make_iterator uses typing::Iterator.

Suggested changelog entry:

* Fix `*args/**kwargs` return types. Add type hinting to `py::make_tuple`.

@InvincibleRMC
Type hint make_tuple / fix *args/**kwargs return type
f15fb97 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
add back commented out panic
1587448
@InvincibleRMC
ignore return std move clang
e7b2f2f 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
fix for mingmw
5ae4342 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
added missing case
00d9f81 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@rwgk
Copy link
Copy Markdown
Collaborator

rwgk commented Nov 12, 2025

@gentlegiantJGC Is there a chance that you could help formally reviewing (and approving) this PR?

gentlegiantJGC
gentlegiantJGC approved these changes Nov 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gentlegiantJGC gentlegiantJGC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

rwgk
rwgk approved these changes Nov 14, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gentlegiantJGC for the review!

Thanks @InvincibleRMC for jumping in to fix this!

@rwgk
Copy link
Copy Markdown
Collaborator

rwgk commented Nov 14, 2025

Oh ... merge conflicts, @InvincibleRMC could you please resolve?

@InvincibleRMC
Copy link
Copy Markdown
Contributor Author

InvincibleRMC commented Nov 14, 2025

Oh ... merge conflicts, @InvincibleRMC could you please resolve?

should be good now

@rwgk rwgk merged commit 42cda75 into pybind:master Nov 14, 2025
85 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Nov 14, 2025
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Jan 21, 2026
@BrewTestBot BrewTestBot mentioned this pull request Feb 17, 2026
Merged
@yamatveev
Copy link
Copy Markdown
Contributor

yamatveev commented Feb 18, 2026

FYI: https://gitlab.com/tango-controls/pytango/-/merge_requests/977

@jdblischak jdblischak mentioned this pull request Feb 18, 2026
Closed
@kounelisagis kounelisagis mentioned this pull request Feb 18, 2026
Merged
@wdconinc wdconinc mentioned this pull request Mar 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgk rwgk rwgk approved these changes

+1 more reviewer

@gentlegiantJGC gentlegiantJGC gentlegiantJGC approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@InvincibleRMC @rwgk @yamatveev @gentlegiantJGC