Move tomlkit dependency to dev group#5990
Merged
rwgk merged 1 commit intopybind:masterfrom Feb 23, 2026
Merged
Conversation
tomlkit is used only in the packaging tests which are not ordinarily run as part of the normal workflow of a user or downstream packager. Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
Collaborator
|
Looks good to me, but I'm wondering, how did you stumble over this / what problem does this solve? |
Contributor
Author
|
Fedora ELN tracks the dependencies of RHEL packages in preparation for the next RHEL major version, and pybind11 is included in RHEL as a dependency of a couple packages. pybind11 3.0 introduced new build dependencies on scikit-build-core and tomlkit. The former seems unavoidable short of changing the project to a different build backend. While tomlkit would indeed not introduce any additional dependencies, since it is not actually needed here to build and test a package from the source tarball, there is no reason to add it. |
rwgk
approved these changes
Feb 23, 2026
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
Thanks for the explanation!
rwgk
pushed a commit
to rwgk/pybind11
that referenced
this pull request
Mar 30, 2026
tomlkit is used only in the packaging tests which are not ordinarily run as part of the normal workflow of a user or downstream packager. Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tomlkit is used only in the packaging tests which are not ordinarily run as part of the normal workflow of a user or downstream packager.