Fix repl failing to start on python 3.8, address review comments#8
Merged
dhoomakethu merged 2 commits intomainfrom Feb 21, 2024
Merged
Fix repl failing to start on python 3.8, address review comments#8dhoomakethu merged 2 commits intomainfrom
dhoomakethu merged 2 commits intomainfrom
Conversation
d050d5b to
1130fb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accidentally deleted remote branch for #5
Reopening again
Closes #2
The issue was with typing module on python3.8 and use of from future import annotations.
Works also on the other versions of python
For conversation refer #5