fix(metrics): use rule as path

[alexppg]

Using the real path as metric created useless metrics. When using a
dynamic rule, it creates unique paths with every metric, which makes it
impossible to aggregate metrics to the same endpoint.

For example, having the next endpoint:

@self.app.route("/something/<myid>/update")
    def root(myid):

Created the next metrics:

http_server_requests_seconds_count{method="GET",uri="/something/1/update"} 4.0
http_server_requests_seconds_count{method="GET",uri="/something/2/update"} 4.0
http_server_requests_seconds_count{method="GET",uri="/something/3/update"} 4.0
http_server_requests_seconds_count{method="GET",uri="/something/4/update"} 4.0

With those metrics, it's impossible to filter that method, since the uri is always different. With this fix, the generated metrics are:

http_server_requests_seconds_count{method="GET",uri="/something/<myid>/update"} 4.0
http_server_requests_seconds_count{method="GET",uri="/something/<myid>/update"} 4.0
http_server_requests_seconds_count{method="GET",uri="/something/<myid>/update"} 4.0
http_server_requests_seconds_count{method="GET",uri="/something/<myid>/update"} 4.0

[avara1986]

Interesting! good change! :)

[alexppg]

@avara1986 Do you know if there's a real possibility that a request wouldn't have this attribute? I've tested locally and even without using dynamic values for the endpoints works. But the test doesn't, without the conditional. I'm not sure if it really should be like this and have a fallback or is the test_client that's not really complete.

[avara1986]

I figure out this weekend :)

[avara1986]

@alexppg the problem is not in tests. request.url_rule is None when you get 404 response. It makes sense if you visit a non-exists page therefore, you haven't a url_rule.

PR approved

PD: sorry, one week late... 🙈

[coveralls]

Pull Request Test Coverage Report for Build 876

• 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.001%) to 99.25%

---

Totals
Change from base Build 861:	0.001%
Covered Lines:	1587
Relevant Lines:	1599

---

💛 - Coveralls

[alexppg]

Shouldn't the CI execute the tests? @avara1986

[avara1986]

Shouldn't the CI execute the tests? @avara1986

Yess, but sometimes Travis has a big queue of jobs 😛