Add mypy check to github actions

[ooigavin]

Fixes # 166

Changes proposed in this PR:

• Add type checking in github actions using mypy
• Improve type hinting in the code

[coveralls]

Pull Request Test Coverage Report for Build 942

• 16 of 16 (100.0%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 99.156%

---

Totals
Change from base Build 939:	0.0%
Covered Lines:	1644
Relevant Lines:	1658

---

💛 - Coveralls

[ooigavin]

Hi @avara1986 I have added the mypy checks into github actions, still working on reducing the errors & adding more type hints. However I have some questions regarding the pipfile and the lock file. Not too familiar with it as I normally use pip & virtualenv in my own projects. But I do understand the concept of a lock file from other package managers like yarn.

When I generated the lockfile I see that not only did i add the mypy dependency, I also upgraded the minor versions of other dependencies (which should be non-breaking). But what I would like to ask is what the markers do in the lockfile, cause I noticed that regenerating the lockfile added a few of these markers.

My python env is 3.7.5

[avara1986]

Hi @ooigavin,

It's normal that if you run pipenv lock you see new changes (not only your changes). His behavior is about this definition:

lightstep>=4.4.8

The most of pyms dependencies are "greater or equeal to [version]" and each time you run pipenv pipenv lock if a package has a new version, the pipfile.lock will be updated.

The new markers means that this library updated the Python version dependencie (python_version < '3.8', python_version > '3.5', etc)

I hope this help 😄

[ooigavin]

Goddit, thanks! one other thing I wanted to check, I am used to creating small commits for each change i make. However sometimes I think maintainers prefer PRs to contain a single commit? Not sure what is the convention for this project.

[avara1986]

IMHO, i like both. One big PR or a lot of small PRs 😃 BUT, if you are playing the Hacktoberfest I think a lot of small PRs with one or two lines updated could be considered as SPAM 👍

[ooigavin]

oh what i meant is in a single PR, is it alright if it contains many commits, or should it just contain one commit containing all the changes? Only intend to submit a single PR for this

[avara1986]

I read that i want sorry....:joy: No, you can do all commits that you want, It's ok 1 or 1000 :+1:

[ooigavin]

Have added more type hints and reduced some of the mypy errors, left some whr I wasnt too sure about the typing alone.

[avara1986]

Great PR @ooigavin ! is ready to review and merge or do you want to add more commits? 👍

[ooigavin]

I've looked thru most of the codebase, and added the types whr I was confident to add them. I'm ready to merge, unless you need me to make any changes?