gh-136066: simplify platform._platform()#136069
Merged
picnixz merged 2 commits intopython:mainfrom Jun 29, 2025
Merged
Conversation
sobolevn
reviewed
Jun 28, 2025
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Can you please provide a benchmark for realistical platforms and some unrealistically big ones?
Member
Author
For realistic ones, there should be no difference (because the strings are REALLY small). For unrealistically big ones, I'll write them. |
picnixz
commented
Jun 28, 2025
Misc/NEWS.d/next/Library/2025-06-28-11-12-12.gh-issue-136066.WqsKka.rst
Outdated
Show resolved
Hide resolved
picnixz
changed the title
platform._platform()platform._platform()
Member
Author
|
For the benchmarks: ./python -m pyperf timeit -s 'import platform; s="-" *1_000_000' 'platform._platform(s)'On a PGO+LTO build: |
serhiy-storchaka
approved these changes
Jun 28, 2025
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
platform._platform#136066