gh-136421: Load _datetime static types during interpreter initialization#136583
Merged
ZeroIntensity merged 15 commits intopython:mainfrom Jul 21, 2025
Merged
gh-136421: Load _datetime static types during interpreter initialization#136583ZeroIntensity merged 15 commits intopython:mainfrom
_datetime static types during interpreter initialization#136583ZeroIntensity merged 15 commits intopython:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_datetimeis a special module, because it's the only non-builtin C extension that contains static types. As such, it would initialize static types in the module's execution function, which can run concurrently. Since static type initialization is not thread-safe, this caused crashes. This fixes it by moving the initialization of_datetime's static types to interpreter startup (where all other static types are initialized), which is already properly protected through other locks._datetimein sub-interpreters in the same time may crash the process #136421