gh-138234: clarify returncode behavior for subprocess_exec vs subprocess_shell#138536
Merged
kumaraditya303 merged 3 commits intopython:mainfrom Mar 21, 2026
Merged
Conversation
andreuu-tsai
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
|
All commit authors signed the Contributor License Agreement. |
andreuu-tsai
force-pushed
the
doc-asyncio-subprocess-returncode-in-shell
branch
from
b833aaf to
93cdda2
Compare
gpshead
reviewed
Sep 6, 2025
Member
gpshead
left a comment
gpshead
left a comment
There was a problem hiding this comment.
there are several places in subprocess.rst itself that could be updated in a similar manner to mention the potential difference between shell=False (default) and shell=True.
kumaraditya303
requested changes
Oct 3, 2025
Contributor
kumaraditya303
left a comment
kumaraditya303
left a comment
There was a problem hiding this comment.
awaiting subprocess docs changes and CLA
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
…hell Update asyncio.subprocess returncode documentation: - For create_subprocess_exec, negative values (-N) indicate termination by signal N (POSIX). - For create_subprocess_shell, the return code follows the invoked shell’s exit status (e.g. 128+N for signals in bash/sh).
andreuu-tsai
force-pushed
the
doc-asyncio-subprocess-returncode-in-shell
branch
from
5fac6df to
979128f
Compare
kumaraditya303
approved these changes
Mar 21, 2026
kumaraditya303
added
topic-asyncio
needs backport to 3.13
|
Thanks @andreuu-tsai for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 21, 2026
… with `shell=True` (pythonGH-138536) (cherry picked from commit 8a531f8) Co-authored-by: andreuu-tsai <32549555+andreuu-tsai@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 21, 2026
… with `shell=True` (pythonGH-138536) (cherry picked from commit 8a531f8) Co-authored-by: andreuu-tsai <32549555+andreuu-tsai@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
|
GH-146254 is a backport of this pull request to the 3.14 branch. |
|
GH-146255 is a backport of this pull request to the 3.13 branch. |
kumaraditya303
added a commit
that referenced
this pull request
Mar 21, 2026
…d with `shell=True` (GH-138536) (#146254) gh-138234: clarify returncode behavior for subprocesses created with `shell=True` (GH-138536) (cherry picked from commit 8a531f8) Co-authored-by: andreuu-tsai <32549555+andreuu-tsai@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
kumaraditya303
added a commit
that referenced
this pull request
Mar 21, 2026
…d with `shell=True` (GH-138536) (#146255) gh-138234: clarify returncode behavior for subprocesses created with `shell=True` (GH-138536) (cherry picked from commit 8a531f8) Co-authored-by: andreuu-tsai <32549555+andreuu-tsai@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
CuriousLearner
added a commit
to CuriousLearner/cpython
that referenced
this pull request
Mar 22, 2026
* upstream/main: (1475 commits) Docs: replace all `datetime` imports with `import datetime as dt` (python#145640) pythongh-146153: Use `frozendict` in pure python fallback for `curses.has_key` (python#146154) pythongh-138234: clarify returncode behavior for subprocesses created with `shell=True` (python#138536) pythongh-140947: fix contextvars handling for server tasks in asyncio (python#141158) pythonGH-100108: Add async generators best practices section (python#141885) pythonGH-145667: Merge `GET_ITER` and `GET_YIELD_FROM_ITER` (pythonGH-146120) pythongh-146228: Better fork support in cached FastPath (python#146231) pythongh-146227: Fix wrong type in _Py_atomic_load_uint16 in pyatomic_std.h (pythongh-146229) pythongh-145980: Fix copy/paste mistake in binascii.c (python#146230) pythongh-146092: Raise MemoryError on allocation failure in _zoneinfo (python#146165) pythongh-91279: Note `SOURCE_DATE_EPOCH` support in `ZipFile.writestr()` doc (python#139396) pythongh-146196: Fix Undefined Behavior in _PyUnicodeWriter_WriteASCIIString() (python#146201) pythongh-143930: Reject leading dashes in webbrowser URLs pythongh-145916: Soft-deprecate ctypes.util.find_library (pythonGH-145919) pythongh-146205: Check the errno with != 0 in close impls in select module (python#146206) pythongh-146171: Fix nested AttributeError suggestions (python#146188) pythongh-146099: Optimize _GUARD_CODE_VERSION+IP via function version symbols (pythonGH-146101) pythongh-145980: Add support for alternative alphabets in the binascii module (pythonGH-145981) pythongh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format (python#145756) pythongh-145177: Add emscripten run --test, uses test args from config.toml (python#146160) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update asyncio.subprocess returncode documentation:
asyncio.create_subprocess_shelldoes not consistently result in negativereturncodeon signal termination #138234📚 Documentation preview 📚: https://cpython-previews--138536.org.readthedocs.build/