gh-144490: Fix test_cppext on Windows#144628
Merged
vstinner merged 1 commit intopython:mainfrom Feb 9, 2026
Merged
Conversation
Don't include pycore_backoff.h and pycore_cell.h on Windows, since they emit C++ compiler warnings.
Member
Author
|
On Windows with Python built in debug mode, TestInteralCAPI of test_cppext fails the following warnings: |
Member
Author
|
!buildbot AMD64 Windows11 Non-Debug |
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit 8c9afa5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F144628%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Member
Author
|
"AMD64 Windows11 Non-Debug PR" job is waiting for 2 hours for a Refleak job to complete. I will not wait longer for this job to run. Hugo asked for a fix for Tuesday to prepare Python releases. I tested my fix locally, so let me merge this fix. We will see later if my fix works on the buildbot. |
vstinner
added a commit
to vstinner/cpython
that referenced
this pull request
Feb 9, 2026
Don't include pycore_backoff.h and pycore_cell.h on Windows, since they emit C++ compiler warnings. (cherry picked from commit 245ba3d)
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
Don't include pycore_backoff.h and pycore_cell.h on Windows, since they emit C++ compiler warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't include pycore_backoff.h and pycore_cell.h on Windows, since they emit C++ compiler warnings.