gh-142518: Add thread safety notes for the buffer protocol#145911
Merged
lysnikolaou merged 4 commits intopython:mainfrom Mar 18, 2026
Merged
gh-142518: Add thread safety notes for the buffer protocol#145911lysnikolaou merged 4 commits intopython:mainfrom
lysnikolaou merged 4 commits intopython:mainfrom
Conversation
lysnikolaou
requested review from
AA-Turner,
ZeroIntensity and
willingc
as code owners
49 tasks
Doc/c-api/typeobj.rst
Outdated
|
|
||
| * The export counter decrement in step (1) must be atomic. | ||
|
|
||
| * Resource cleanup when the counter reaches zero must be reentrant, |
Contributor
There was a problem hiding this comment.
not sure why it needs to be re-entrant, can you give an example?
Member
Author
There was a problem hiding this comment.
What I meant here is that resource cleanup should only happen once. Or, in general, be handled gracefully. Should I update the wording you think?
kumaraditya303
approved these changes
Mar 16, 2026
Contributor
kumaraditya303
left a comment
kumaraditya303
left a comment
There was a problem hiding this comment.
One question otherwise LGTM
kumaraditya303
approved these changes
Mar 18, 2026
|
Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 18, 2026
…honGH-145911) (cherry picked from commit 847f83e) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
|
GH-146106 is a backport of this pull request to the 3.14 branch. |
lysnikolaou
added a commit
that referenced
this pull request
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--145911.org.readthedocs.build/