gh-145966: Fix _csv DIALECT_GETATTR macro silently masking non-AttributeError exceptions#145974
Open
raminfp wants to merge 3 commits intopython:mainfrom
Open
gh-145966: Fix _csv DIALECT_GETATTR macro silently masking non-AttributeError exceptions#145974raminfp wants to merge 3 commits intopython:mainfrom
raminfp wants to merge 3 commits intopython:mainfrom
Conversation
…AttributeError exceptions The DIALECT_GETATTR macro in dialect_new() unconditionally called PyErr_Clear() when PyObject_GetAttrString() failed, which suppressed all exceptions including MemoryError, KeyboardInterrupt, and RuntimeError. Now only AttributeError is cleared; other exceptions propagate via the existing error handling path.
picnixz
requested changes
Mar 15, 2026
Misc/NEWS.d/next/Library/2026-03-15-00-00-00.gh-issue-145966.tCI0uD4I.rst
Outdated
Show resolved
Hide resolved
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
…fy NEWS, fix blank lines
picnixz
reviewed
Mar 15, 2026
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
approved these changes
Mar 15, 2026
Member
|
Could you use |
picnixz
reviewed
Mar 16, 2026
Comment on lines
+500
to
+512
| #define DIALECT_GETATTR(v, n) \ | ||
| do { \ | ||
| if (v == NULL) { \ | ||
| v = PyObject_GetAttrString(dialect, n); \ | ||
| if (v == NULL) { \ | ||
| if (PyErr_ExceptionMatches(PyExc_AttributeError)) { \ | ||
| PyErr_Clear(); \ | ||
| } \ | ||
| else { \ | ||
| goto err; \ | ||
| } \ | ||
| } \ | ||
| } \ |
Member
There was a problem hiding this comment.
Suggested change
| #define DIALECT_GETATTR(v, n) \ | |
| do { \ | |
| if (v == NULL) { \ | |
| v = PyObject_GetAttrString(dialect, n); \ | |
| if (v == NULL) { \ | |
| if (PyErr_ExceptionMatches(PyExc_AttributeError)) { \ | |
| PyErr_Clear(); \ | |
| } \ | |
| else { \ | |
| goto err; \ | |
| } \ | |
| } \ | |
| } \ | |
| #define DIALECT_GETATTR(v, n) \ | |
| do { \ | |
| if (v == NULL) { \ | |
| if (PyObject_GetOptionalAttrString(dialect, n, &v) < 0) { \ | |
| goto err; \ | |
| } \ | |
| } \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only clear
AttributeErrorinDIALECT_GETATTR; let other exceptions (e.g.MemoryError,KeyboardInterrupt) propagate._csv:DIALECT_GETATTRmacro silently masks non-AttributeErrorexceptions #145966