Skip to content

gh-146388: Add null check for sym_new(ctx) in make_bottom #146389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
A0su wants to merge 4 commits into
base: main
Choose a base branch
from
+4 −0
Open

gh-146388: Add null check for sym_new(ctx) in make_bottom #146389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e99eb55
add null check for sym_new(ctx) in make_bottom
A0su Mar 24, 2026
8d0ef9d
fix typo on var name
A0su Mar 24, 2026
d2ff2c5
use out_of_space instead of out_of_space_ref to align return type
A0su Mar 24, 2026
a6a2fde
add blurb
A0su Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add a null check for :func:`sym_new(ctx)` in :func:`make_bottom`
Copy link
Member

@Fidget-Spinner Fidget-Spinner Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't tell much. Can it be more descriptive please? Something like

Handle when JIT optimizer runs out of space when dealing with contradictions.

3 changes: 3 additions & 0 deletions Python/optimizer_symbols.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1684,6 +1684,9 @@ static JitOptSymbol *
make_bottom(JitOptContext *ctx)
{
JitOptSymbol *sym = sym_new(ctx);
if (sym == NULL) {
return out_of_space(ctx);
}
sym->tag = JIT_SYM_BOTTOM_TAG;
return sym;
}
Expand Down
Loading