Skip to content

gh-94991 Make wave._wave_params public -> wave.wave_params #94992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
f4hy wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-94991 Make wave._wave_params public -> wave.wave_params #94992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35cc786
Make `_wave_params` public -> `wave_params`
f4hy Jul 18, 2022
1e1beaa
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 19, 2022
c01cc8c
add the now public wave_params to __all__
f4hy Jul 19, 2022
3938ef3
add an alias to keep compatibility if anyone used the private type
f4hy Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions Lib/wave.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
import sys


__all__ = ["open", "Error", "Wave_read", "Wave_write"]
__all__ = ["open", "Error", "Wave_read", "Wave_write", "wave_params"]

class Error(Exception):
pass
Expand All @@ -86,8 +86,9 @@ class Error(Exception):

_array_fmts = None, 'b', 'h', None, 'i'

_wave_params = namedtuple('_wave_params',
'nchannels sampwidth framerate nframes comptype compname')
wave_params = namedtuple('wave_params',
'nchannels sampwidth framerate nframes comptype compname')
_wave_params = wave_params # alias to keep compatibility

def _byteswap(data, width):
swapped_data = bytearray(len(data))
Expand Down Expand Up @@ -335,9 +336,9 @@ def getcompname(self):
return self._compname

def getparams(self):
return _wave_params(self.getnchannels(), self.getsampwidth(),
self.getframerate(), self.getnframes(),
self.getcomptype(), self.getcompname())
return wave_params(self.getnchannels(), self.getsampwidth(),
self.getframerate(), self.getnframes(),
self.getcomptype(), self.getcompname())

def getmarkers(self):
return None
Expand Down Expand Up @@ -526,7 +527,7 @@ def setparams(self, params):
def getparams(self):
if not self._nchannels or not self._sampwidth or not self._framerate:
raise Error('not all parameters set')
return _wave_params(self._nchannels, self._sampwidth, self._framerate,
return wave_params(self._nchannels, self._sampwidth, self._framerate,
self._nframes, self._comptype, self._compname)

def setmark(self, id, pos, name):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2022-07-19-02-20-29.gh-issue-94991.kRGnFh.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make wave._wave_params public