Special cases Enum and some special props to be non-final, refs #11699#11713
Merged
JukkaL merged 2 commits intopython:masterfrom Dec 13, 2021
sobolevn:issue-11699
Merged
Special cases Enum and some special props to be non-final, refs #11699#11713JukkaL merged 2 commits intopython:masterfrom sobolevn:issue-11699
Enum and some special props to be non-final, refs #11699#11713JukkaL merged 2 commits intopython:masterfrom
sobolevn:issue-11699
Conversation
This was referenced Dec 11, 2021
This comment has been minimized.
This comment has been minimized.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/core/task.py:45: error: Cannot override writable attribute "value" with a final one
alerta (https://github.com/alerta/alerta)
- alerta/models/enums.py:159: error: Cannot override writable attribute "value" with a final one
|
JukkaL
approved these changes
Dec 13, 2021
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks! It looks like _name_ and _value_ are not accepted at runtime, even without overriding, but this is minor.
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My naive attempt to fix bug with some special
Enumprops which are treated asFinal.I just special case it and ignore them.
This looks like the simplest solution. And it fits
Enumpretty well, becauseEnumis special in how class / instances are treated.Closes #11699