Disallow to use TypeGuard type outside of .ret_type, refs #11765#11790
Closed
sobolevn wants to merge 2 commits intopython:masterfrom
sobolevn:issue-11765
Closed
Disallow to use TypeGuard type outside of .ret_type, refs #11765#11790sobolevn wants to merge 2 commits intopython:masterfrom sobolevn:issue-11765
TypeGuard type outside of .ret_type, refs #11765#11790sobolevn wants to merge 2 commits intopython:masterfrom
sobolevn:issue-11765
Conversation
Member
Author
|
@97littleleaf11 @hauntsaninja any feedback? 🙂 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now TypeGuard is required to be in the function's return type position. In other places it is just a
booltype. But, we start to raise an error.To be honest, PEP does not mention this, but I think that it is a reasonable thing to do.
Closes #11765
CC @erictraut