Adds Literal type math#11992
Closed
sobolevn wants to merge 3 commits intopython:masterfrom
sobolevn:issue-11990
Closed
Adds Literal type math#11992sobolevn wants to merge 3 commits intopython:masterfrom sobolevn:issue-11990
Literal type math#11992sobolevn wants to merge 3 commits intopython:masterfrom
sobolevn:issue-11990
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
|
|
||
| _hasher: Final = _Hasher() | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
The name literal of this literals.py file is different from the Literal in typing, which is an old and annoying conflict. I am not sure whether they should put in same file.
Collaborator
There was a problem hiding this comment.
I think that the old and new functionality are quite distinct, so having in the same file could be confusing. One option would be to move the old code into a new module with a different name.
Collaborator
There was a problem hiding this comment.
@JukkaL Any suggestions on the new name for the old part?
Member
There was a problem hiding this comment.
Perhaps simple_expr.py? Or even literal_expr.py, though I don't think that helps much.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #11990