Properly support union of TypedDicts as dict literal context#14505
Merged
JukkaL merged 1 commit intopython:masterfrom Jan 23, 2023
Merged
Properly support union of TypedDicts as dict literal context#14505JukkaL merged 1 commit intopython:masterfrom
JukkaL merged 1 commit intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JukkaL
approved these changes
Jan 23, 2023
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Looks good! Nice that this fixes an old type inference bug as well.
|
Awesome! What version will this be available in? |
Member
Author
|
I guess it will be included in 1.0 |
|
@ilevkivskyi Cool, when is that set to launch? |
Collaborator
|
1.0 should be out within the next week or two. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14481 (regression)
Fixes #13274
Fixes #8533
Most notably, if literal matches multiple items in union, it is not an error, it is only an error if it matches none of them, so I adjust the error message accordingly.
An import caveat is that an unrelated error like
{"key": 42 + "no"}can cause no item to match (an hence an extra error), but I think it is fine, since we still show the actual error, and avoiding this would require some dirty hacks.Also note there was an (obvious) bug in one of the fixtures, that caused one of repros not repro in tests, fixing it required tweaking an unrelated test.