Allow arbitrary overriding of comparision methods#2584
Closed
z33ky wants to merge 1 commit intopython:masterfrom
z33ky:master
Closed
Allow arbitrary overriding of comparision methods#2584z33ky wants to merge 1 commit intopython:masterfrom z33ky:master
z33ky wants to merge 1 commit intopython:masterfrom
z33ky:master
Conversation
Member
|
This PR is missing tests for the new functionality. But first I would like to see an issue filed requesting this change -- I would like to see some specific use cases to decide what to do here, and completely excluding the comparisons from compatibility with the base class feels wrong (they are not as unrelated as |
Collaborator
|
Agreed that this would benefit from discussion. |
Member
|
Closing this PR, let's continue the discussion in #2661. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subclasses should be allowed to override these with differing argument types.
The documentation explicitly allows returning non-
boolvalues for instance.This also allows typeshed to define comparison methods for
objectand still error on comparisons of unrelated types (likestr() < int()).