Make testfinegrained use dmypy_server#4699
Merged
Conversation
msullivan
force-pushed
the
dmypy-fg-testing
branch
2 times, most recently
from
4402316 to
fba8c4c
Compare
msullivan
force-pushed
the
dmypy-fg-testing
branch
from
fba8c4c to
b328f74
Compare
JukkaL
approved these changes
Mar 8, 2018
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
LGTM! It's good to have tests that are closer to real-world use cases, and as a bonus this also cleans up the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the fine-grained test harness to use
dmypy_serverfor performing fine-grained updates instead of usingupdatedirectly. This allows it to test the change detection logic in the server, which is actually quite fiddly.I want to land this before landing any other changes that affect the change detection logic (such as #4623, #4664, or some in-progress work optimizing deletes).
This found one bug already running our existing test suite. I've skipped the test and filed the bug as #4698.
This does not appear to slow down the fine-grained tests any.