Conversation
There are two parts to this:
1. Look harder for the start of a function, since decorators can make
it tricky to find.
2. Be more defensive about handling dodgy line number info.
Our line numbers aren't reliable enough to be crashing the
reporter over. This fixes a crash related to attrs.
Fixes #4563
JukkaL
approved these changes
Apr 26, 2018
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
LGTM -- feel free to merge once the builds have passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two parts to this:
it tricky to find.
Our line numbers aren't reliable enough to be crashing the
reporter over. This fixes a crash related to attrs.
Fixes #4563