docs/more_types: Fix typo in advanced self-types#8006
Merged
ilevkivskyi merged 2 commits intopython:masterfrom Nov 25, 2019
Merged
docs/more_types: Fix typo in advanced self-types#8006ilevkivskyi merged 2 commits intopython:masterfrom
ilevkivskyi merged 2 commits intopython:masterfrom
Conversation
The type of self should be `Tag[str]` here.
Contributor
Author
|
@ilevkivskyi Thanks for the improvements to self typing in #7860! I'm quite excited about this. Noticed this small typo however while I was reading the added documentation. |
The `export` methods seems to actually return an `str` instead of `T` even when a converter is given.
Contributor
Author
|
I found another typo in docs. Added another commit to fix that one too. |
ilevkivskyi
approved these changes
Nov 25, 2019
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Oops... Thanks for the fixes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type of self should be
Tag[str]here.