Bump pyinstaller to 6.0.*#10800
Merged
JelleZijlstra merged 3 commits intopython:mainfrom Sep 29, 2023
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
approved these changes
Sep 29, 2023
| else: | ||
| _TargetArch: TypeAlias = None | ||
| _SuportedTargetArchParam: TypeAlias = object | ||
| _SuportedTargetArchParam: TypeAlias = Unused |
| @@ -1,127 +0,0 @@ | |||
| from _typeshed import Incomplete, ReadableBuffer, Unused | |||
Member
There was a problem hiding this comment.
Seems like this file still exists, why was it deleted? The contents do look very different from what's currently in the stub.
Collaborator
Author
There was a problem hiding this comment.
Valid question, this is not immediately obvious:
This module is not part of the public API and was only included with bare minimal typing for the Manifest type.
The Manifest class no longer exists (it is now a bytes-string)
See the PyInstaller.depend.utils entry in stubtest_allowlist.txt commented with # Most modules are not meant to be used, yet are not marked as private
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10752