seaborn: complete and fix axisgrid module#11096
Conversation
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| x: ColumnName | _Vector | None = None, | ||
| y: ColumnName | _Vector | None = None, | ||
| hue: ColumnName | _Vector | None = None, | ||
| kind: Literal["scatter", "kde", "hist", "hex", "reg", "resid"] = "scatter", |
There was a problem hiding this comment.
This was changed to str earlier thanks to the feedback on the PR that introduced seaborn stubs. Upon further investigation, the function seems to only accepts this set of strings (also verified in the repl).
| diag_vars: NDArray[Incomplete] | None # array of `str` | ||
| diag_axes: NDArray[Incomplete] | None # array of `Axes` | ||
| diag_vars: list[str] | None | ||
| diag_axes: list[Axes] | None |
There was a problem hiding this comment.
These are lists, not sure why I typed them as arrays earlier
| data: DataFrame, | ||
| data: DataFrame | _SupportsDataFrame, |
There was a problem hiding this comment.
seaborn version 0.13 started supporting other data frames that support the __dataframe__ protocol: https://seaborn.pydata.org/whatsnew/v0.13.0.html#support-for-alternate-dataframe-libraries
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
I did not compare this to the implementation, but all the changes LGTM.
2 participants
No description provided.