Fix a few invalid noqa comments#11497
Merged
JelleZijlstra merged 2 commits intopython:mainfrom Feb 29, 2024
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks, suggested two other changes while we're here
stubs/WebOb/webob/exc.pyi
Outdated
| @@ -41,7 +41,7 @@ class WSGIHTTPException(Response, HTTPException): | |||
| def generate_response(self, environ: WSGIEnvironment, start_response: StartResponse) -> Iterable[bytes]: ... | |||
| @property | |||
| def wsgi_response(self) -> Self: ... # type:ignore[override] | |||
Member
There was a problem hiding this comment.
Suggested change
| def wsgi_response(self) -> Self: ... # type:ignore[override] | |
| def wsgi_response(self) -> Self: ... # type: ignore[override] |
Collaborator
Author
There was a problem hiding this comment.
I've seen (and done) that often. Idk if it's just outside a formatter's purview (Ruff formatter/black). Maybe Ruff linting and/or flake8-pyi could check for this stylistic issue.
Member
There was a problem hiding this comment.
Yes, this could be a good lint rule.
Collaborator
Author
There was a problem hiding this comment.
There's 40 instances of type:ignore in the code. I could fix them all at once here if you'd like. It's not too far off the original scope of this PR anyway
stubs/WebOb/webob/exc.pyi
Outdated
| @property | ||
| def wsgi_response(self) -> Self: ... # type:ignore[override] | ||
| def __str__(self) -> str: ... # type:ignore[override] # noqaY029 | ||
| def __str__(self) -> str: ... # type:ignore[override] # noqa: Y029 |
Member
There was a problem hiding this comment.
Suggested change
| def __str__(self) -> str: ... # type:ignore[override] # noqa: Y029 | |
| def __str__(self) -> str: ... # type: ignore[override] # noqa: Y029 |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #11496