[pywin32] Mark stub-only NamedTuples as @type_check_only#15514
Merged
brianschubert merged 1 commit intopython:mainfrom Mar 15, 2026
Merged
[pywin32] Mark stub-only NamedTuples as @type_check_only#15514brianschubert merged 1 commit intopython:mainfrom
@type_check_only#15514brianschubert merged 1 commit intopython:mainfrom
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
brianschubert
changed the title
@type_check_only
brianschubert
approved these changes
Mar 15, 2026
Collaborator
brianschubert
left a comment
brianschubert
left a comment
There was a problem hiding this comment.
Thanks! I was surprised that this wasn't already flagged by python/mypy#19574. Turns out there was a bug in how I was detecting if a named tuple is expressible using the class syntax, which incorrectly suppressed these hits. Now fixed in python/mypy@565e42f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.