Skip to content

os.path.{abspath, basename, join} should accept _PathType #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sid-kap wants to merge 2 commits into from
Closed

os.path.{abspath, basename, join} should accept _PathType #1960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
364867f
abspath and basename should accept _PathType
sid-kap Mar 13, 2018
710f310
Join should also take PathType
sid-kap Mar 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions stdlib/3/os/path.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ defpath = ... # type: str
devnull = ... # type: str

# ----- os.path function stubs -----
def abspath(path: AnyStr) -> AnyStr: ...
def basename(path: AnyStr) -> AnyStr: ...
def abspath(path: _PathType) -> AnyStr: ...
def basename(path: _PathType) -> AnyStr: ...

if sys.version_info >= (3, 5):
def commonpath(paths: Sequence[AnyStr]) -> AnyStr: ...
Expand Down Expand Up @@ -76,7 +76,7 @@ if sys.version_info < (3, 0):
@overload
def join(__p1: bytes, __p2: bytes, __p3: bytes, __p4: Text, *p: _PathType) -> Text: ...
else:
def join(path: AnyStr, *paths: AnyStr) -> AnyStr: ...
def join(path: _PathType, *paths: _PathType) -> AnyStr: ...

def normcase(path: AnyStr) -> AnyStr: ...
def normpath(path: AnyStr) -> AnyStr: ...
Expand Down