socket.create_connection source_address is optional.#4133
Merged
srittau merged 4 commits intopython:masterfrom May 28, 2020
Merged
socket.create_connection source_address is optional.#4133srittau merged 4 commits intopython:masterfrom
srittau merged 4 commits intopython:masterfrom
Conversation
JelleZijlstra
approved these changes
May 28, 2020
srittau
reviewed
May 28, 2020
stdlib/2and3/socket.pyi
Outdated
| def create_connection(address: Tuple[Optional[str], int], | ||
| timeout: Optional[float] = ..., | ||
| source_address: Tuple[Union[bytearray, bytes, Text], int] = ...) -> socket: ... | ||
| source_address: Optional[Tuple[Union[bytearray, bytes, Text], int\] = ...) -> socket: ... |
Collaborator
There was a problem hiding this comment.
These seems to be an extraneous backslash here.
Collaborator
There was a problem hiding this comment.
Ah sorry, the backslash was probably supposed to be a closing bracket. So this is missing now. :)
Contributor
Author
There was a problem hiding this comment.
Sorry about that. Should be better now.
Collaborator
|
@bwelling Nearly there. Stubtest fails, because |
Collaborator
|
Travis-CI seems to hiccup, but it passed now: https://travis-ci.org/github/python/typeshed/builds/692261015 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4116.