third_part peewee

[trim21]

• EXCLUDED
• SQL
• JOIN
• DJANGO_MAP
• OP
• DQ
• chunked
• ImproperlyConfigured
• Field
• UUIDField
• BinaryUUIDField
• IPField
• BlobField
• DoubleField
• TimeField
• DateTimeField
• BareField
• DateField
• DecimalField
• BooleanField
• AutoField
• BigAutoField
• TimestampField
• CharField
• FixedCharField
• IntegerField
• BigIntegerField
• SmallIntegerField
• FloatField
• BitField
• BigBitField
• TextField
• ForeignKeyField
• PrimaryKeyField
• ManyToManyField
• IdentityField
• Table
• Tuple
• Case
• Database
• MySQLDatabase
• SqliteDatabase
• PostgresqlDatabase
• Value
• prefetch
• Check
• Model
• DeferredThroughModel
• fn
• Column
• SchemaManager
• DataError
• NotSupportedError
• InterfaceError
• DatabaseError
• ProgrammingError
• OperationalError
• InternalError
• IntegrityError
• AsIs
• QualifiedNames
• Select
• Cast
• ValuesList
• DoesNotExist
• Context
• Window
• Index
• ModelIndex
• CompositeKey
• DeferredForeignKey
• Proxy
• DatabaseProxy

[srittau]

Just two things I noticed while skimming through the stubs:

• Just use foo: Any for fields, instead of foo: Any = .... The assignment is redundant.
• When you have not typed an argument, just leave out the type, instead of using Any. For example foo(x, y) -> None: ..., instead of foo(x: Any, y: Any) -> None: .... This makes it clear that the argument is not typed yet, but practically it is identical to Any.

[trim21]

Thanks for your suggestions

[trim21]

Most of code are generated by mypy stubgen, I'm still working on it.

[vmotso]

Hi there

My company is very interested in this PR.
@trim21 can you tell us approximately when this PR is planned to be completed?
We will be very grateful.

Thanks

[trim21]

I’m not sure. Feel free to start a new pr based on my existing work.

…

------------------ Original ------------------ From: Vitalii Motso <notifications@github.com&gt; Date: Wed,Aug 5,2020 10:31 PM To: python/typeshed <typeshed@noreply.github.com&gt; Cc: Trim21 <github@trim21.me&gt;, Mention <mention@noreply.github.com&gt; Subject: Re: [python/typeshed] third_part peewee (#4262) Hi there My company is very interested in this PR. @trim21 can you tell us approximately when this PR is planned to be completed? We will be very grateful. Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[gvanrossum]

May I suggest that it’s probably better to publish this as a separate package following PEP 561.

[srittau]

Just a heads up: Next week we will reshuffle the layout of typeshed. This means that the files in this PR will also need to be moved. This shouldn't be much of a problem, though, as there should be no conflicts.