stubtest: fix on windows#4455
Conversation
Co-authored by: Akuli
| def tm_gmtoff(self) -> int: ... | ||
| if sys.version_info >= (3, 6): | ||
| @property | ||
| def tm_zone(self) -> str: ... |
There was a problem hiding this comment.
This does exist in 3.5 on Linux.
There was a problem hiding this comment.
The docs say that it's platform specific before Python 3.6 https://docs.python.org/3/library/time.html
|
There might be non-windows systems that lack |
|
Yup! Also generally speaking, we don't do a great job of platforms outside of linux, win32, darwin (and up until we got stubtest running on windows, win32 had a lot of room for improvement too). For instance, we run flake8-pyi in typeshed CI and it currently only recognises four sys.platform values: https://github.com/ambv/flake8-pyi/blob/cdd527b601d95da1b5223a6be54ce0c675771b4b/pyi.py#L271 And of course, we'd be receptive to improvements for other platforms if we ever got issues or PRs :-) |
3 participants
Resolves #4448
Co-authored by: Akuli