Re-organize directory structure#4971
Conversation
|
OK, here is the situation: all tests pass, but I temporarily disabled two tests:
Somehow This is now ready for review, I am aiming to land this tomorrow morning. |
srittau
left a comment
There was a problem hiding this comment.
Thanks! LGTM, with one question.
tests/mypy_test.py
Outdated
| if name == PY2_NAMESPACE: | ||
| continue | ||
| mod, _ = os.path.splitext(name) | ||
| if mod not in supported_versions or supported_versions[mod] > (major, minor): |
There was a problem hiding this comment.
Should we print a warning or even fail the test if mod is not in supported_versions?
There was a problem hiding this comment.
Yes, I think we should, I was thinking about allowing some unrelated files in that directory (like some scripts etc). But we actually should keep directory structure clean. I will update this and will also add in a separate PR later a test that ensures stdlib and stubs have strict directory structure.
|
I believe I have pytype_test working again; it requires first a change to pytype itself (google/pytype#821), then an update to the test (26862d4). (It'll take at least a day for the pytype change to be reviewed and merged, so it still makes sense to disable pytype_test first and re-enable it later.) |
|
@rchen152 Great, thanks! I will then merge this now with pytype test disabled, and you can re-enable it whenever ready. |
|
Each stub now shows up with "1 contributor" on github, but if I look at the blame (by pressing |
This is a GitHub bug I think |
Follow up fo #4971 Co-authored-by: Ivan Levkivskyi <ilevkivskyi@dropbox.com>
See discussion in #2491
This PR needs a mypy commit that supports new directory structure (including
--custom-typeshed-dirfor standard library) landed in mypy master, which may take another day or two.cc @JukkaL